Skip to content

Conversation

@bergos
Copy link
Contributor

@bergos bergos commented Nov 22, 2025

Closes #663

  • Adds a built-in widget section.
  • Moves the built-in widget to that section.
  • Keeps the widget and the editors/viewers section.

This PR doesn't touch the text of Editors and Viewers. Those sections should be updated once the terminology is added.

@nicholascar nicholascar added the UI For SHACL 1.2 UI spec label Nov 24, 2025
Copy link

@danielbeeke danielbeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the scope of the issue, seems good to me.

However, some viewers need to take more complete control over how multiple values of a property at a focus node are rendered.
The only example of such a viewer in SHACL UI is <a href="#ValueTableViewer"><code>shui:ValueTableViewer</code></a>, which displays
all values of a property as an HTML table.
In those cases, the notions of generic add and delete buttons do not apply.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In those cases, the notions of generic add and delete buttons do not apply.
In such cases, the notions of generic add and delete buttons do not apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI For SHACL 1.2 UI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Move built-in widgets to a section closer to the end

5 participants