Skip to content

Softening language around explicitly assigning implicit ARIA semantics #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 11, 2020
Merged

Softening language around explicitly assigning implicit ARIA semantics #237

merged 12 commits into from
Aug 11, 2020

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Jul 25, 2020 •
edited by pr-preview bot
Loading

Closes #236

Preview | Diff

@patrickhlauke
Re-hardening to still use NOT RECOMMENDED normatively
b0d2725 
while this is synonymous with SHOULD NOT, it better conveys the intent. Still keeps the lengthier explanation of why it's not recommended, and that the "danger" of adverse effects is minimal if authors do do it.
@patrickhlauke patrickhlauke mentioned this pull request Jul 27, 2020
Closed
carmacleod
carmacleod reviewed Jul 28, 2020
View reviewed changes
patrickhlauke and others added 7 commits July 30, 2020 21:47
@patrickhlauke
Change dash to comma
c135e3e
@scottaohara
Merge branch 'gh-pages' into patrickhlauke-issue236
ad55734
@scottaohara
add examples
a3bbf44
@scottaohara
document formatting updates
59b977f
@scottaohara
remove list notes per new example provided
6de7837
@scottaohara
cut down this text per the added examples which call this out.
dcc8894
@scottaohara
note updates
0ad16b1 
remove the bit about bugs, as that’s unfortunately not always accurate.
also removed the “older” bit, as there may still be some modern user agents which do not properly expose all elements.
patrickhlauke
patrickhlauke commented Aug 10, 2020
View reviewed changes
patrickhlauke and others added 3 commits August 10, 2020 21:06
@patrickhlauke
Add some fixes/corrections and extra button example
81b2e45 
as `<button role="button">` is such a staple of the genre, worth adding an actual example...and clarifying that no there are likely no actual side effects
@scottaohara
sentence update
c90e327
@scottaohara
additional wordsmithing
a78d2c1
@scottaohara scottaohara mentioned this pull request Aug 11, 2020
Closed
@scottaohara
Copy link
Member

as far as i'm concerned, this PR will also close #228 and #223 per the new notes / examples added by this pr

@stevefaulkner stevefaulkner merged commit a7bf6c0 into gh-pages Aug 11, 2020
@scottaohara scottaohara deleted the patrickhlauke-issue236 branch August 11, 2020 22:50
This was referenced Aug 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevefaulkner stevefaulkner stevefaulkner approved these changes

@scottaohara scottaohara scottaohara approved these changes

+1 more reviewer

@carmacleod carmacleod carmacleod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Softening the language around unnecessary explicit role?

4 participants

@patrickhlauke @scottaohara @stevefaulkner @carmacleod