Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous step in Deserialize JSON-LD to RDF Algorithm? #278

Closed
kasei opened this issue Dec 23, 2019 · 3 comments
Closed

Extraneous step in Deserialize JSON-LD to RDF Algorithm? #278

kasei opened this issue Dec 23, 2019 · 3 comments

Comments

@kasei
Copy link

@kasei kasei commented Dec 23, 2019

Deserialize JSON-LD to RDF Algorithm step 1.3.2.5.1 says:

item is a value object, list object, or a node object.

Is this meant to be validation that might raise an error condition? If not, would it be better included as a note, not its own step?

@gkellogg gkellogg added the wr:open label Dec 24, 2019
@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 24, 2019

No, not a validation step, an assertion of truth. It could be a note at the beginning of 1.3.2.5.2, instead.

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 24, 2019

@kasei see update in PR #286. Please indicate if this addresses the issue.

@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 26, 2019

@gkellogg looks good, thanks!

gkellogg added a commit that referenced this issue Dec 26, 2019
@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management Dec 26, 2019
gkellogg added a commit that referenced this issue Dec 26, 2019
@gkellogg gkellogg closed this Jan 10, 2020
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.