Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed use of "append" and "add" in reference to an RdfGraph in Deserialize JSON-LD to RDF Algorithm #279

Closed
kasei opened this issue Dec 23, 2019 · 2 comments

Comments

@kasei
Copy link

@kasei kasei commented Dec 23, 2019

Deserialize JSON-LD to RDF Algorithm step 1.3.2.5.3 says:

Append a triple composed of subject, property, and the result of using the Object to RDF Conversion algorithm passing item and list triples to triples, unless the result is null, indicating a non-well-formed resource that has to be ignored.

The use of "append" language in reference to triples is confusing here, as triples is an RdfGraph which can have triples added to it with the add method (which is what step 1.3.2.5.4 does).

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 24, 2019

@kasei see update in PR #286. Please indicate if this addresses the issue.

@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 26, 2019

@gkellogg 1.3.2.5.2 now includes an extra "using its":

to triples using its using its add method

Other than that, yes, this looks good. Thanks.

@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management Dec 26, 2019
@gkellogg gkellogg closed this Jan 10, 2020
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.