Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Object to RDF Conversion language regarding datatype well-formedness #282

Closed
kasei opened this issue Dec 24, 2019 · 2 comments
Closed

Comments

@kasei
Copy link

@kasei kasei commented Dec 24, 2019

Object to RDF Conversion step 6 says:

If datatype is not well-formed, return null.

However, I believe the condition here should be expanded to:

If datatype is not null and is not well-formed, return null.

This is because datatype can be set to null in step step 5, and I do not believe null is a well-formed datatype IRI (but do believe that the intent here is for this step to be skipped if datatype is null). However, the language used for "well-formedness" is also a bit confusing:

A literal is well-formed if it has the lexical form of a string, any datatype IRI is well-formed, and any language tag is well-formed according to section 2.2.9 of [BCP47].

This comes in a section that only seems to define IRIs, blank node identifiers, and literals for well-formedness. I interpret "any datatype IRI is well-formed" to mean that a datatype must be a well-formed IRI, but it would be nice to see the language improved to make that explicit, since in this case the algorithm is explicitly testing a datatype for well-formedness.

This proposed condition language for step 6 would also match the style of step 7 which says:

If item has an @language entry which is not well-formed, return null.

(testing for existence as well as for well-formedness)

@gkellogg gkellogg added the wr:open label Dec 24, 2019
gkellogg added a commit that referenced this issue Dec 24, 2019
…-formed if it is not null, and to specify that the check is for a well-formed IRI.

For #282.
@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 24, 2019

@kasei see update in PR #286. Please indicate if this addresses the issue.

@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 26, 2019

@gkellogg looks good, thanks!

gkellogg added a commit that referenced this issue Dec 26, 2019
…-formed if it is not null, and to specify that the check is for a well-formed IRI.

For #282.
@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management Dec 26, 2019
gkellogg added a commit that referenced this issue Dec 26, 2019
…-formed if it is not null, and to specify that the check is for a well-formed IRI.

For #282.
@gkellogg gkellogg closed this Jan 10, 2020
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.