Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with expansion of null @value values. #292

Closed
kasei opened this issue Dec 30, 2019 · 2 comments
Closed

Issue with expansion of null @value values. #292

kasei opened this issue Dec 30, 2019 · 2 comments

Comments

@kasei
Copy link

@kasei kasei commented Dec 30, 2019

Expand test t0019 seems to reveal an issue with the Expansion algorithm step 15.2:

If the value of result's @value entry is null, then set result to null.

I believe this needs to return null instead of just updating the value of result. This will prevent that null from being converted to an empty array in step 21.

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 30, 2019

@kasei good catch, moved it below the check for @json, and also check for empty array.

Please acknowledge.

@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management Dec 30, 2019
@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 31, 2019

@gkellogg looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.