add literal property #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I intended to make a matching PR to the main spec but I accidentally commit to main. I could back it out but if it could be reviewed here it would save churn, if this PR is going to be merged soon anyway. Pinging a few extra people who were mainly involved in the discussion on the call just in case... @dginev @brucemiller @NSoiffer |
dginev
approved these changes
Mar 26, 2025
Contributor
dginev
left a comment
dginev
left a comment
There was a problem hiding this comment.
Reads well to me, thank you.
|
I'm good with this, too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the last call, this adds
:legacyalongside:commonand:literalproperties.Not changed in this PR but the file with the expanded definitions of these properties,
https://w3c.github.io/mathml-docs/literal-common-properties
has lots of TeX such as$x^2$ but that is only automatic in issues and direct github markdown rendering, as we are using gh-pages and Jekyll we'd need to load it in the page template, or just show the tex as source with backtick markup, or we could use mathml. (mentioning this now as it may come up in review, but can be fixed editorially after this PR is handled)
$x^2$which is probably intended to be rendered by MathJax as here