Fix a couple of typos: no "format" field and audio/video mix-up #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec incorrectly referenced the `audio-encoding-offer` message from within the description of the video payload property. Also, the description of the payload property mentioned the `format` field of `audio-encoding-offer` and `video-encoding-offer` messages, but these fields do not exist. This update references the `codec-name` field instead.
markafoltz
approved these changes
Jan 20, 2022
github-actions bot
added a commit
that referenced
this pull request
Jan 20, 2022
SHA: 3beedbd Reason: push, by @mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec incorrectly referenced the
audio-encoding-offermessage from within the description of the video payload property.Also, the description of the payload property mentioned the
formatfield ofaudio-encoding-offerandvideo-encoding-offermessages, but these fields do not exist. This update references thecodec-namefield instead.Preview | Diff