Skip to content

Conversation

wangw-1991
Copy link
Contributor

@wangw-1991 wangw-1991 commented Apr 24, 2024

Add an entire flow chart to make the entire process clearer.


Preview | Diff

@wangw-1991
Copy link
Contributor Author

Hi, @mfoltzgoogle. Can you help review this? Thanks.

@anssiko anssiko requested a review from markafoltz April 24, 2024 06:07
@anssiko
Copy link
Member

anssiko commented Apr 24, 2024

@wangw-1991 thank you for this great contribution!

My expectation is this diagram is aligned with the normative text in the specification and is considered non-normative similarly to examples and notes given it is an appendix and a diagram. PTAL @mfoltzgoogle for alignment with the normative text in the specification.

@tidoust please let us know if we should explicitly mark this as non-normative.

@backkem FYI

@wangw-1991
Copy link
Contributor Author

My expectation is this diagram is aligned with the normative text in the specification and is considered non-normative similarly to examples and notes given it is an appendix and a diagram. PTAL @mfoltzgoogle for alignment with the normative text in the specification.

Acutally, I first send this entire flow chart to @mfoltzgoogle to comfirm the whole process. Mark think this is great and suggest me to add it in the spec. Please take a look again, Mark.

@anssiko anssiko self-requested a review April 24, 2024 07:13
@chrisn
Copy link
Member

chrisn commented Apr 24, 2024

This looks really good! It would be nice to see diagrams to show the metadata and application message exchanges too, as a suggestion.

@wangw-1991
Copy link
Contributor Author

This looks really good! It would be nice to see diagrams to show the metadata and application message exchanges too, as a suggestion.

Thanks for the suggestion. I don't show the metadata and application message exchanges here because there are many different types of metadata and application data. The use of abstract representation here means it is applicable to all types and it can also simplify the chart. Do you think it is reasonable?

@chrisn
Copy link
Member

chrisn commented Apr 24, 2024

I think this diagram is really good as is, so no suggestion to change it. Additional diagrams, if we make them, could be specific to different use cases or scenarios, e.g., establishing a streaming session.

@markafoltz
Copy link
Contributor

LGTM with Francois' suggestions applied. Thank you again for this contribution!

Co-authored-by: François Daoust <fd@tidoust.net>
@markafoltz markafoltz merged commit 362a2fd into w3c:main Apr 25, 2024
github-actions bot added a commit that referenced this pull request Apr 25, 2024
SHA: 362a2fd
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants