-
Notifications
You must be signed in to change notification settings - Fork 22
Add entire flow chart. #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @mfoltzgoogle. Can you help review this? Thanks. |
@wangw-1991 thank you for this great contribution! My expectation is this diagram is aligned with the normative text in the specification and is considered non-normative similarly to examples and notes given it is an appendix and a diagram. PTAL @mfoltzgoogle for alignment with the normative text in the specification. @tidoust please let us know if we should explicitly mark this as non-normative. @backkem FYI |
Acutally, I first send this entire flow chart to @mfoltzgoogle to comfirm the whole process. Mark think this is great and suggest me to add it in the spec. Please take a look again, Mark. |
This looks really good! It would be nice to see diagrams to show the metadata and application message exchanges too, as a suggestion. |
Thanks for the suggestion. I don't show the metadata and application message exchanges here because there are many different types of metadata and application data. The use of abstract representation here means it is applicable to all types and it can also simplify the chart. Do you think it is reasonable? |
I think this diagram is really good as is, so no suggestion to change it. Additional diagrams, if we make them, could be specific to different use cases or scenarios, e.g., establishing a streaming session. |
LGTM with Francois' suggestions applied. Thank you again for this contribution! |
Co-authored-by: François Daoust <fd@tidoust.net>
SHA: 362a2fd Reason: push, by mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Add an entire flow chart to make the entire process clearer.
Preview | Diff