-
Notifications
You must be signed in to change notification settings - Fork 9
Review sec1.5 wv #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review sec1.5 wv #240
Conversation
Please remove |
Ugh, sorry. Removed now. |
The text of section 1.5 has been part of discussions on github and in the telecons. Changing the wording can not be seen as simply editorial because of the reliance on the current text. |
I'm confused - this proposal was in response to the following on the
mailinglist:
people having concrete suggestion on how to better write section 1.5
*given the current definitions of RDF 1.2 semantics* please step up and
write down such badly needed proposals.
It also does not change any wording but rather restructures and concretizes.
…On Sat, Sep 13, 2025, 7:18 a.m. Andy Seaborne ***@***.***> wrote:
*afs* left a comment (w3c/rdf-concepts#240)
<#240 (comment)>
The text of section 1.5 has been part of discussions on github and in the
telecons. Changing the wording can not be seen as simply editorial because
of the reliance on the current text.
—
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2PLMFCR2NFSZIKSVQEJH33SP4O5AVCNFSM6AAAAACGLFK3W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOBYGEYTGOJQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Rendered display of the PR : section 1.5: https://raw.githack.com/william-vw/rdf-concepts/review_sec1.5_wv/spec/index.html#section-triple-terms-reification |
I am saying that this PR is on a sensitive area and should not be treated as "editorial". I didn't say it made changes. |
I appreciate this attempt to improve clarity and approachability (qualities sometimes hard to balance). We did some in #214 and #219 (perhaps that might clarify some reasoning about the current state). I agree with @afs's comment, and we need to weigh the words carefully. Since this change rearranges and adds example text (which looks promising), it is wise to avoid changing too much wording (there seems to be some of that; perhaps for the better, some do worry me a bit). Since the inline questions in comments make the changes harder to see (for me), and regardless must not be part of the results, I'd appreciate if you remove those @william-vw. I do appreciate their content though, and you might find it useful to add comments in the diff view to motivate; or if you are unsure of changes, you can propose them there as well (with comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some exemplifying additions, rearrangements and corrections (see "encode" vs. "denote") that this PR seeks may prove very valuable. But the inline HTML comments need to be removed; and I think at least the way it uses "metadata about the triple term" needs to be addressed.
I removed the inline comments. They can still be found in the initial commit. (Sorry, they were never meant to be permanent, next time I will use the diff comment function.) I re-added the comments which did not merely explain the edits as diff comments. |
Note that my diff comments and replies are showing up as "pending" - unsure whether you can see them. |
I can't. I suspect that you created them as "review comment", and you did not submit the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the reordering of arguments in this section. It makes a much smoother narrative, and better conveys the idea that we want to convey, IMO.
That being said, I share the concerns raised by @afs and @niklasl. I made a number of suggestion that, I believe, respect the spirit of this PR, while addressing those concerns.
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
This was discussed during the #rdf-star meeting on 18 September 2025. View the transcriptPull Request 240 Review sec1.5 wv (by william-vw)pchampin: it is related to the discussion of reifies <tl> I haven't had a look at this (wasn't aware of it) <gb> Issue 169 definition of reifiers is non-normative and seems vague (by rat10) [needs discussion] [propose closing] [ms:CR] niklasl: I need to look closely at this PR, but I have the same general impression. Yet, I still need to confirm. <Zakim> pfps, you wanted to note that we still have w3c/rdf-star-wg#169 niklasl: It is editorial, which means it is not necessarily CR related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with @TallTed's suggestions
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
No problem - it's an editors job. It looks like everything is resolved and can be merged soon. |
In response to Enrico's message, I had a look at Section 1.5. I personally found it a bit abstract and difficult to read. This is an attempt to make the section more concrete and reduce its complexity.
I added justifications for the edits as in-line HTML comments.
Preview | Diff