Skip to content

Conversation

davidlehn
Copy link
Contributor

@davidlehn davidlehn commented Dec 18, 2018

An attempt to restore markup sanity.

Includes commit from #321. Pull that first. (Removed commit.)

Quite possible this will cause conflicts in all other PRs. If those are pulled in first I can update this PR.


Preview | Diff

@msporny
Copy link
Member

msporny commented Dec 18, 2018

Merge conflicts due to a ton of PRs from @grantnoble ... please fix and I'll pull this in.

@davidlehn davidlehn force-pushed the fix-markup branch 2 times, most recently from 5a4311b to 20358b8 Compare December 18, 2018 18:02
@davidlehn
Copy link
Contributor Author

Updated. Pulling this in may cause conflicts with some other PRs. And looks like they often don't follow a strict whitespace and indent style. Can fix those up later as things are merged.

- Fix various <p> and </p> issues.
- Fix missing closing </a>.
- Normalize some whitespace usage.
- Add missing </section>.
Match to section levels.
@grantnoble
Copy link

grantnoble commented Dec 19, 2018

@davidlehn, my apologies for stomping all over your changes with my PRs! If you tell me what style conventions we want (number of spaces/tabs before <p> tags, etc.) I can do this grunt work, leaving you to concentrate on the technical aspects of the doc.

@davidlehn
Copy link
Contributor Author

@grantnoble No problem. Some pain, but I'll live. ;-) I'm rebasing right now and hopefully my changes get merged in before other people go and cause chaos again!

I guessed on a style. Just wanted doc to be consistent one way or another. Was doing 2 space indents for markup and code, blank lines before sections and various places, proper header levels, etc.

@grantnoble
Copy link

@davidlehn I'll hold off on any further PRs then until yours is in. And I agree that any style is better than none, as long as its consistent! :-)

- Switch tabs to 2 spaces.
- Fix all tags to 2 spaces per level.
- Add wrapper appendix.
- Close section.
- Normalize whitespace and indents.
- Add term links.
@davidlehn
Copy link
Contributor Author

@msporny Rebased again and added some more fixes as needed. Ready for a look over. Please merge soon. ;-) Unsure about the higher level appendix name. Feel free to change that.

Added a bonus respec simplification.

@msporny msporny merged commit 1f69427 into w3c:gh-pages Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants