-
Notifications
You must be signed in to change notification settings - Fork 124
added example of issuer with object as value #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
index.html
Outdated
"type": ["VerifiableCredential", "UniversityDegreeCredential"], | ||
<span class="highlight">"issuer": { | ||
"id": "https://example.com/keys/foo.jwk", | ||
"type": "jwk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to define this in the JSON-LD context or use something like urn:example:jwk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed in 3c5b319
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this change works.
Signed-off-by: Brent <brent.zundel@gmail.com>
I've been thinking about this PR over the last week or so as I was on the fence about it. Fundamentally, I think the example is an anti-pattern that we don't want people to use, for the following reason: The PR suggests that people should use public keys to identify issuers. This is a bad practice because you don't get key rotation when you do this, which is one of the things that DIDs achieved (and why so many of us are proceeding along those lines). We had started a few years ago ago by using keys as issuers, but we've gone away from doing that over the years because of the bind it puts issuers and verifiers in. Everyone needs to track whose keys are whose and that leads to complex and fragile systems (as exemplified by some of the systems utilizing JWKs as ways to identify issuers). As such, we came up with the
When you go and look at that key (in the DID Document), it's expected that it has a controller or some way of associating it with the entity that controls the key. These keys are usually tied to entities in the DID Document, and thus it enables you to do stuff like this (in the Verifiable Credential):
... which is great for issuers and verifiers, because that's a long lived identifier that doesn't break when you rotate keys. This example goes against that very hard earned lesson, and thus I think we should defer pulling this example into the specification. |
Overcome by PR #715, which has been merged. |
Addresses issue #709
Signed-off-by: Brent brent.zundel@gmail.com
Preview | Diff