Add tests for Event.srcElement and Event.returnValue #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
pushed a commit
to miketaylr/dom
that referenced
this pull request
Mar 30, 2018
This was referenced Mar 30, 2018
Build PASSEDStarted: 2018-03-30 21:40:02 View more information about this build on: |
annevk
approved these changes
Apr 3, 2018
dom/interfaces.html
Outdated
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| <h1>DOM IDL tests</h1> | |||
| <div id=log></div> | |||
|
|
|||
miketaylr
pushed a commit
to miketaylr/dom
that referenced
this pull request
Apr 5, 2018
miketaylr
pushed a commit
to miketaylr/dom
that referenced
this pull request
Apr 5, 2018
miketaylr
pushed a commit
to miketaylr/dom
that referenced
this pull request
Apr 6, 2018
See whatwg/dom#625 for details.
annevk
force-pushed
the
miketaylr/dom/625
branch
from
795381e
to
17ca4be
Compare
|
Addressed my own nit. |
annevk
pushed a commit
to miketaylr/dom
that referenced
this pull request
Apr 9, 2018
Unfortunately the web depends on these. They are intentionally defined in such a way to not offer capabilities beyond the non-historical API for events. Tests: web-platform-tests/wpt#10258. Fixes whatwg#625.
annevk
pushed a commit
to miketaylr/dom
that referenced
this pull request
Apr 9, 2018
Unfortunately the web depends on these. They are intentionally defined in such a way to not offer capabilities beyond the non-historical API for events. Tests: web-platform-tests/wpt#10258. Fixes whatwg#625 and fixes whatwg#627.
|
Hmm, these tests cause harness failures due to not wrapping the listeners appropriately. |
See whatwg/dom#625 for details.
annevk
force-pushed
the
miketaylr/dom/625
branch
from
17ca4be
to
22ee639
Compare
|
Fixed that. |
annevk
pushed a commit
to whatwg/dom
that referenced
this pull request
Apr 9, 2018
Unfortunately the web depends on these. They are intentionally defined in such a way to not offer capabilities beyond the non-historical API for events. Tests: web-platform-tests/wpt#10258. Fixes #625 and fixes #627.
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Apr 16, 2018
https://bugs.webkit.org/show_bug.cgi?id=184415 Reviewed by Darin Adler. LayoutTests/imported/w3c: Import test coverage from web-platform-tests/wpt#10258. * web-platform-tests/dom/events/AddEventListenerOptions-passive-expected.txt: * web-platform-tests/dom/events/AddEventListenerOptions-passive.html: * web-platform-tests/dom/events/Event-constructors.html: * web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch-expected.txt: * web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch.html: * web-platform-tests/dom/events/Event-defaultPrevented-expected.txt: * web-platform-tests/dom/events/Event-defaultPrevented.html: * web-platform-tests/dom/events/Event-dispatch-click.html: * web-platform-tests/dom/events/Event-dispatch-detached-click.html: * web-platform-tests/dom/events/Event-dispatch-other-document.html: * web-platform-tests/dom/events/Event-initEvent.html: * web-platform-tests/dom/events/Event-returnValue-expected.txt: Added. * web-platform-tests/dom/events/Event-returnValue.html: Added. * web-platform-tests/dom/events/EventListener-handleEvent.html: * web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue-expected.txt: * web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue.html: * web-platform-tests/dom/events/w3c-import.log: * web-platform-tests/dom/interfaces-expected.txt: * web-platform-tests/interfaces/dom.idl: Source/WebCore: Update Event.returnValue setter to match the latest DOM specification after: - whatwg/dom#626 In particular, the returnValue setter is now a no-op if the new flag value is true. If the input flag value is false, it only sets the 'canceled' flag if the event is cancelable and the event’s in passive listener flag is unset. Test: imported/w3c/web-platform-tests/dom/events/Event-returnValue.html * dom/Event.cpp: (WebCore::Event::setLegacyReturnValue): (WebCore::Event::setCanceledFlagIfPossible): (WebCore::Event::preventDefault): * dom/Event.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@230664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
pull bot
pushed a commit
to Yannic/chromium
that referenced
this pull request
Jan 6, 2021
srcElement and returnValue were specified in [1] and have WPTs in [2]. cancelBubble is documented in [3] and has a WPT which passes in all browsers in [4]. [1] whatwg/dom#407 [2] web-platform-tests/wpt#10258 [3] https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble [4] https://wpt.fyi/results/dom/events/Event-cancelBubble.html Fixed: 692695 Change-Id: Ia7113a9996a0e272829a3e81bf751412444e9ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610947 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840397}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
srcElement and returnValue were specified in [1] and have WPTs in [2]. cancelBubble is documented in [3] and has a WPT which passes in all browsers in [4]. [1] whatwg/dom#407 [2] web-platform-tests/wpt#10258 [3] https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble [4] https://wpt.fyi/results/dom/events/Event-cancelBubble.html Fixed: 692695 Change-Id: Ia7113a9996a0e272829a3e81bf751412444e9ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610947 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840397} GitOrigin-RevId: 3de46b6619a24531b2277b243ac39484a8ca5505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(these tests were already r+'d in #4790, but splitting them out from the
window.eventstuff so they can land independent of that).r? @annevk