manifest.py: Fixed updating reftest graph when node changes to other type #9719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to other type Slightly altered line 94 so reftest_changes is also set when reftest_node changes to support, etc. Closes web-platform-tests#9671
jgraham
reviewed
Feb 28, 2018
tools/manifest/manifest.py
Outdated
| else: | ||
| new_type, manifest_items = old_type, self._data[old_type][rel_path] | ||
| if old_type == "reftest" and new_type != old_type: | ||
| if (old_type == "reftest" and new_type != old_type) or (old_type=="reftest_node" and new_type!=old_type): |
There was a problem hiding this comment.
I think this can be written old_type in ["reftest", "reftest_node"] and new_type != old_type.
There was a problem hiding this comment.
Sorry, didn't think about that earlier. Made that change now.
I'm not sure about how to write tests so I'll have to look into that
There was a problem hiding this comment.
It'd be more idiomatic to use a tuple (("reftest", "reftest_node")) here.
Build PASSEDStarted: 2018-02-28 18:15:16 View more information about this build on: |
|
This turned into #9732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly altered line 94 so reftest_changes is also set when
reftest_node changes to support, etc.
Closes #9671
This change is