Annotate encoder/decoders with EventTarget on ondequeue events. #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be an oversight from when ondequeue events were added. Allows the idlharness.js test to start passing.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 3, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 3, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 6, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d
|
Ping @aboba |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 7, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222139 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101909}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222139 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101909}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222139 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101909}
chrisn
approved these changes
Feb 8, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 20, 2023
…s.js test., a=testonly Automatic update from web-platform-tests Fix dependencies for WebCodecs idlharness.js test. WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222139 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101909} -- wpt-commits: cb996520530ee3d49995a81e3654b4bc90e92d7d wpt-pr: 38358
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 23, 2023
…s.js test., a=testonly Automatic update from web-platform-tests Fix dependencies for WebCodecs idlharness.js test. WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222139 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101909} -- wpt-commits: cb996520530ee3d49995a81e3654b4bc90e92d7d wpt-pr: 38358
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
WebCodecs uses events, but without specifying the right deps, the test harness doesn't know how to process those. w3c/webcodecs#637 will fix the imported IDL to pare down the last remaining failures (except metadata since we intentionally don't have that yet). R=dbaron Bug: 1412203 Change-Id: I62424285c49d1cf84a8f17081a5fb158da9a042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222139 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101909}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be an oversight from when ondequeue events were added. Allows the idlharness.js test to start passing.
Preview | Diff