Skip to content

Conversation

@github-actions
Copy link
Contributor

Some changes were detected in the IDL since last time the @webref/idl package was released. Please review the IDL changes below.

If the IDL changes look good, a new version of the @webref/idl package should be released. This pull request bumps the patch part of the version number in packages/idl/package.json.

Please make sure that the changes to be released do not warrant bumping the major or minor part of the version number.

If all looks good (and if all goes well) merging this pull request will trigger the release of the package to npm.

diff --ignore-trailing-space '--exclude=package.json' '--unified=3' idl/node_modules/@webref/idl/gamepad.idl webref/packages/idl/gamepad.idl
--- idl/node_modules/@webref/idl/gamepad.idl	1985-10-26 08:15:00.000000000 +0000
+++ webref/packages/idl/gamepad.idl	2021-03-18 04:23:40.126155869 +0000
@@ -24,6 +24,7 @@
 enum GamepadMappingType {
   "",
   "standard",
+  "xr-standard",
 };
 
 [Exposed=Window]
diff --ignore-trailing-space '--exclude=package.json' '--unified=3' idl/node_modules/@webref/idl/screen-fold.idl webref/packages/idl/screen-fold.idl
--- idl/node_modules/@webref/idl/screen-fold.idl	1985-10-26 08:15:00.000000000 +0000
+++ webref/packages/idl/screen-fold.idl	2021-03-18 04:23:40.138156172 +0000
@@ -8,7 +8,13 @@
   [SameObject] readonly attribute DevicePosture posture;
 };
 
-enum DevicePosture {
+[SecureContext, Exposed=(Window)]
+interface DevicePosture : EventTarget {
+  readonly attribute DevicePostureType type;
+  attribute EventHandler onchange;
+};
+
+enum DevicePostureType {
   "no-fold",
   "laptop",
   "flat",
diff --ignore-trailing-space '--exclude=package.json' '--unified=3' idl/node_modules/@webref/idl/ua-client-hints.idl webref/packages/idl/ua-client-hints.idl
--- idl/node_modules/@webref/idl/ua-client-hints.idl	1985-10-26 08:15:00.000000000 +0000
+++ webref/packages/idl/ua-client-hints.idl	2021-03-18 04:23:40.138156172 +0000
@@ -9,10 +9,11 @@
 };
 
 dictionary UADataValues {
-  DOMString platform;
-  DOMString platformVersion;
   DOMString architecture;
+  DOMString bitness;
   DOMString model;
+  DOMString platform;
+  DOMString platformVersion;
   DOMString uaFullVersion;
 };
 
diff --ignore-trailing-space '--exclude=package.json' '--unified=3' idl/node_modules/@webref/idl/webtransport.idl webref/packages/idl/webtransport.idl
--- idl/node_modules/@webref/idl/webtransport.idl	1985-10-26 08:15:00.000000000 +0000
+++ webref/packages/idl/webtransport.idl	2021-03-18 04:23:40.142156273 +0000
@@ -23,6 +23,7 @@
     readonly attribute DatagramDuplexStream datagrams;
 };
 
+[Exposed=(Window,Worker)]
 interface DatagramDuplexStream {
   readonly attribute ReadableStream readable;
   readonly attribute WritableStream writable;

@foolip
Copy link
Member

foolip commented Mar 18, 2021

Hmm, so checks haven't run on this PR, how can we know if the tests pass?

The reason must be that this PR was created form GitHub Actions, and to avoid infinite triggering, one actions isn't allowed to trigger another.

@dontcallmedom
Copy link
Member

I think the current approach is that this pull request only gets created if tests don't fail (cf #133) - in particular https://github.com/w3c/webref/runs/2136787167?check_suite_focus=true confirms that the tests succeeded.

@foolip
Copy link
Member

foolip commented Mar 18, 2021

I see. Most of the time merging it would work then, but the tests could start failing on master while the PR is in review. If that happens, will we publish a broken package, or do we run the tests before publishing too?

@dontcallmedom
Copy link
Member

dontcallmedom commented Mar 18, 2021

Tests are run when doing the release too. That being said, the problem you describe remains: if master changes, the review of the diff above is no longer accurate - the release should start from the hash associated with the state at the time this PR is created…

@dontcallmedom
Copy link
Member

that being said, it probably doesn't matter as long as we don't have a clear policy on patch/minor/major versioning

@dontcallmedom
Copy link
Member

that being said, it probably doesn't matter as long as we don't have a clear policy on patch/minor/major versioning

hmm… No, it would also matter in case the diff contains obviously buggy changes (e.g. removal of stable interfaces due to a bug in the crawl)

@tidoust
Copy link
Member

tidoust commented Mar 18, 2021

In particular, there has been a new crawl since this PR was created. I'll close without merging and re-run the job.

@tidoust tidoust closed this Mar 18, 2021
@foolip foolip deleted the release-idl-1616041427 branch March 18, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants