Fix naming logic when dropping duplicate CSS properties #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script that drops duplicate CSS properties in known superseded specs did not follow the exact same file naming logic as that followed by the crawler. It took for granted that the file had to be the spec's shortname if the spec wasn't the current specification, but the logic followed by the crawler is rather that defined in `isLatestLevelThatPasses`: the latest full level that defines some CSS is the one that provides the series CSS extract. This nuance had never led to any problem in this part of the code because a spec that defines superseded content typically does not have a "next" level that is not the current level and that keeps on defining the superseded content. Copying the superseded content to a newer level does not make sense, right? Well, that's what `css-multicol-2` currently does. This update fixes the file naming logic, which should have followed that of the crawler in any case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script that drops duplicate CSS properties in known superseded specs did not follow the exact same file naming logic as that followed by the crawler. It took for granted that the file had to be the spec's shortname if the spec wasn't the current specification, but the logic followed by the crawler is rather that defined in
isLatestLevelThatPasses: the latest full level that defines some CSS is the one that provides the series CSS extract.This nuance had never led to any problem in this part of the code because a spec that defines superseded content typically does not have a "next" level that is not the current level and that keeps on defining the superseded content. Copying the superseded content to a newer level does not make sense, right? Well, that's what
css-multicol-2currently does.This update fixes the file naming logic, which should have followed that of the crawler in any case.