Feature/graphql #40
Feature/graphql #40
Conversation
…tuff. Update readme
- wrong enable setting - use seperate setting for editor
- No need for lodash overhead - merge of lodash does recursivly merge which can be bad and time consuming
…ools curl interprets 000 as timeout
| }; | ||
|
|
||
| public async run(root: any, args: CreatePetMutationArguments, context: GraphQLContext<any, any>): Promise<Pet> { | ||
| const petService = context.container.get<PetService>(PetService); |
There was a problem hiding this comment.
Would be nice to have this over DI, but think for the next step.
| } else { | ||
| /* tslint:disable */ | ||
| // @ts-ignore | ||
| orderedResult.push(null); |
There was a problem hiding this comment.
Could we use undefined as any as T?
There was a problem hiding this comment.
must be null is given from the lib
| }; | ||
|
|
||
| const allFiles = directories.reduce((allDirs, dir) => { | ||
| return allDirs.concat(require('glob').sync(path.normalize(dir))); |
There was a problem hiding this comment.
It there a reason why we don't import glob at the top?
| let connection: Connection; | ||
| beforeAll(async () => connection = await createDatabaseConnection()); | ||
| beforeEach(() => synchronizeDatabase(connection)); | ||
| afterAll(() => closeDatabase(connection)); |
There was a problem hiding this comment.
Even though the closeDatabase function didn't exist before my review commits it has not thrown a error in TS.
Based on this fact any TS errors in integration tests, which don't fail the app hard, will not be detected by the developer.
| }; | ||
|
|
||
| export const synchronizeDatabase = (connection: Connection) => { | ||
| return connection.synchronize(true); |
There was a problem hiding this comment.
We should use migrations as sync is not aligned with migrations and migrations is the truth representation of the schema.
No description provided.