Clean up examples and add more colab buttons #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 48 48
Lines 6998 6998
Branches 1583 1583
=======================================
Hits 4655 4655
Misses 1728 1728
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "# Install k-wave-python if not installed yet (e.g. running in Google Colab)\n", | ||
| "#!pip install git+https://github.com/waltsims/k-wave-python" | ||
| "%%capture\n", | ||
| "!pip install k-wave-python" |
Collaborator
There was a problem hiding this comment.
What if we install only if in colab? We can detect running in colab using the snippet here: https://stackoverflow.com/a/53586419
faridyagubbayli
approved these changes
Feb 15, 2024
Collaborator
faridyagubbayli
left a comment
faridyagubbayli
left a comment
There was a problem hiding this comment.
Looks good, left a non-blocking comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #282