-
Notifications
You must be signed in to change notification settings - Fork 36
Weave generated reference improvements #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdlinville
wants to merge
9
commits into
main
Choose a base branch
from
weave_generated_reference_improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+61,484
−2,544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📚 Mintlify Preview Links🔄 Renamed/Moved (15 total)📄 Pages (15)
✨ Added (9 total)📄 Pages (9)
📝 Changed (7 total)📄 Pages (6)
⚙️ Other (1)
🗑️ Deleted (4 total)View deleted files📄 Pages (4)
🤖 Generated automatically when Mintlify deployment succeeds |
This was referenced Nov 18, 2025
Closed
Observed in #1888
Fixes issues from PR review: - Add weave/reference/python-sdk as first page in Python SDK section - Add weave/reference/typescript-sdk as first page in TypeScript SDK section - Remove service-api/index.mdx generation (landing page is service-api.mdx) - Keep OpenAPI config managed by sync_openapi_spec.py only This ensures proper navigation structure in docs.json.
Prepare for cherry-pick by removing old capitalized file names. New lowercase versions will be added via cherry-pick.
caad229 to
ee47c9f
Compare
… links - Updated generate_typescript_sdk_docs.py to generate lowercase filenames - Regenerated all Weave reference documentation - Fixed broken links in typescript-sdk.mdx landing page (WeaveClient -> weaveclient, etc.) - Fixed broken link in weave/guides/tracking/tracing.mdx - Added new classes: ObjectRef - Added new functions: requirecurrentcallstackentry, requirecurrentchildsummary, weaveaudio, weaveimage, wrapopenai - Updated Service API spec and landing page - Updated docs.json TOC This resolves the 22 broken links caused by case mismatch between generated files and links.
- Updated generate_python_sdk_minimal.py to escape curly braces in docstrings - Curly braces are interpreted as JSX expressions in MDX, so they need to be escaped - Regenerated Python SDK documentation with escaped braces - This fixes the three Mintlify parsing errors: * op.mdx line 24: Could not parse expression with acorn * index.mdx line 3112: Could not parse expression with acorn * weave_client.mdx line 312: Unexpected lazy line in expression
- Python SDK: Remove Pydantic documentation links that reference non-existent concept pages - TypeScript SDK: Fix relative link paths when extracting functions and type aliases * Landing page links use ./typescript-sdk/ prefix * Function/type-alias pages use ../ relative paths - Updated both generators to properly handle link transformations - This fixes 783 broken links reported by the link checker
- Convert typescript-sdk#anchor links to proper relative paths - Function files: (typescript-sdk#op) -> (../type-aliases/op) - Type alias files: (typescript-sdk#op) -> (./op) - This fixes the 6 broken links in op.mdx that reappeared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Weave generation reference bugs discovered in #1888
Second commit fixes some further issues seen in testing in my fork.
TODO: Remove the
WEAVE-REFERENCE-FIXES-SUMMARY.mdwhich summarizes the issues found and fixedFollowup needed upstream
Fixes
Features
Testing
mint dev) after generating the refs freshmint broken-links)Note that PR checks won't be interesting because this doesn't update any
.mdxfiles.