feat: Add reading helm username and password from a secret#95
Conversation
WalkthroughThe changes expand RBAC permissions for batch resources by adding "create," "delete," and "patch" verbs to both configuration and controller files. Additionally, Helm repository credential handling is enhanced to support fetching credentials from Kubernetes Secrets via a new struct and logic in the chart repository code. The test suite is extended to cover these new credential secret scenarios. The Helm chart version and Redis auth settings were also updated in a manifest file. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RepoRelease
participant KubernetesAPI
participant Secret
User->>RepoRelease: Apply()
alt CredentialSecret provided
RepoRelease->>KubernetesAPI: Get Secret (CredentialSecret.Name)
KubernetesAPI-->>RepoRelease: Secret object
RepoRelease->>Secret: Extract username/password (using keys)
RepoRelease->>RepoRelease: Override plain credentials
else No CredentialSecret
RepoRelease->>RepoRelease: Use plain username/password fields
end
RepoRelease->>User: Continue Helm repo logic
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
hack/testing-manifests/wandb/default.yaml (1)
61-67: Redis is installed without authentication – confirm this is intentional for test clusters
Previous test manifests enabledredis.auth.enabled: true; dropping it exposes the instance unauthenticated. If that’s unintended, add the flag back or inject a test password viavalues.redis.auth.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
hack/testing-manifests/wandb/default.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: zacharyblasczyk
PR: wandb/operator#0
File: :0-0
Timestamp: 2025-02-24T15:05:30.333Z
Learning: When handling Helm chart downloads, proper configuration of both repository-level settings (entry.Username/Password) and getter-level options (WithBasicAuth) is essential for authentication to work correctly.
Learnt from: zacharyblasczyk
PR: wandb/operator#0
File: :0-0
Timestamp: 2025-02-24T15:05:30.333Z
Learning: The chart repository authentication in the operator requires both repository-level credential setup (entry.Username/Password) and getter-level authentication (getter.WithBasicAuth) to ensure proper authentication for all registry interactions.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test
- GitHub Check: Build
danielpanzella
deleted the
danielpanzella/infra-321-helm-chart-pull-with-authentication
branch
## [1.20.0](v1.19.3...v1.20.0) (2025-07-02) ### Features * Add reading helm username and password from a secret ([#95](#95)) ([41e76ab](41e76ab))
|
This PR is included in version 1.20.0 🎉 |
3 participants
Summary by CodeRabbit
New Features
Chores
Tests