fix: Prune old helm releases, for real

[danielpanzella]

Summary by CodeRabbit

• Chores
  • Adjusted upgrade process to retain a maximum of 10 release revisions during upgrades.

[coderabbitai]

Walkthrough

A single line was added to the Upgrade method in pkg/helm/chart.go to configure the Helm upgrade action's MaxHistory property, limiting the number of retained release revisions to a set constant. No other changes or logic modifications were made.

Changes

Cohort / File(s)	Change Summary
Helm Upgrade History Limit pkg/helm/chart.go	Sets MaxHistory to a constant (maxReleasesToKeep) in the Upgrade method to limit release history.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• fix: Prune old helm releases #97: Modifies the MaxHistory field in the same file, but during Helm action configuration initialization rather than during upgrade, indicating related approaches to managing release history.

Poem

A hop and a skip, a history capped,
Ten releases kept, the rest are zapped!
With a tweak in the chart,
Helm’s memory is smart—
Now upgrades stay neat,
As bunnies repeat,
“Keep it tidy, that’s the rabbit’s art!” 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b15957 and 5adf7dc.

📒 Files selected for processing (1)

• pkg/helm/chart.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build
• GitHub Check: Test
• GitHub Check: build-and-scan

🔇 Additional comments (2)

pkg/helm/chart.go (2)

158-163: MaxHistory correctly capped during Upgrade
Setting client.MaxHistory guarantees that every upgrade run prunes old revisions beyond the configured limit. Nice catch—this avoids stale release buildup in clusters.

---

50-55: Verify duplicated MaxHistory configuration
InitConfig already pins config.Releases.MaxHistory = maxReleasesToKeep. Because action.Upgrade.Run() overwrites cfg.Releases.MaxHistory with its own MaxHistory value when that field is non-zero, the new line is effectively redundant—but harmless. Please confirm this intentional duplication, or consider removing one assignment to keep the codebase DRY.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch danielpanzella/prune-helm-history

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jsbroks]

This PR is included in version 1.20.3 🎉