fix: Explicitly specify the desired value if IMG for make#99
fix: Explicitly specify the desired value if IMG for make#99zacharyblasczyk merged 1 commit intomainfrom
Conversation
WalkthroughA single CI workflow file was updated to export IMG from IMAGE_TAG_BASE and VERSION before the make docker-build docker-push step. No other steps, variables, or public interfaces were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
52-55: Minor: pass IMG inline and harden the shellPassing IMG directly to make avoids reliance on export, and adding strict mode plus quoting is safer.
Apply:
- - name: Build and Push - run: | - export IMG=$IMAGE_TAG_BASE:$VERSION - make docker-build docker-push + - name: Build and Push + run: | + set -euo pipefail + make docker-build docker-push IMG="${IMAGE_TAG_BASE}:${VERSION}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Build
🔇 Additional comments (1)
.github/workflows/release.yaml (1)
52-55: Explicit IMG export correctly overrides Makefile default — LGTMMakefile defines
IMG ?= controller:latestand references${IMG}in docker-build, docker-push, and kustomize targets, so exporting IMG beforemakewill override the default.
### [1.21.1](v1.21.0...v1.21.1) (2025-09-11) ### Bug Fixes * Explicitly specify the desired value if IMG for make ([#99](#99)) ([68a68f3](68a68f3))
|
This PR is included in version 1.21.1 🎉 |
Summary by CodeRabbit