Skip to content

fix: Explicitly specify the desired value if IMG for make#99

Merged
zacharyblasczyk merged 1 commit intomainfrom
danielpanzella/fix-release-action
Sep 11, 2025
Merged

fix: Explicitly specify the desired value if IMG for make#99
zacharyblasczyk merged 1 commit intomainfrom
danielpanzella/fix-release-action

Conversation

@danielpanzella
Copy link
Copy Markdown
Contributor

@danielpanzella danielpanzella commented Sep 11, 2025

Summary by CodeRabbit

  • Chores
    • Updated the release workflow to more reliably publish container images by explicitly passing the image tag to build and push steps. This reduces the risk of mismatched tags and improves the stability and predictability of releases. No changes to application behavior or user-facing features. No downtime or configuration changes required for users.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 11, 2025

Walkthrough

A single CI workflow file was updated to export IMG from IMAGE_TAG_BASE and VERSION before the make docker-build docker-push step. No other steps, variables, or public interfaces were changed.

Changes

Cohort / File(s) Change Summary
CI workflow
.github/workflows/release.yaml
Inserted export IMG=$IMAGE_TAG_BASE:$VERSION in the Build and Push step prior to running make docker-build docker-push; no other modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title references IMG and make, which matches the change that exports IMG in the release workflow, but its phrasing "if IMG for make" is grammatically unclear and could be more concise and readable.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I twitch my whiskers at tags that gleam,
IMG now bottled from base and stream.
A hop, a push, the docker’s done,
Release moon rises—builds all run.
In pipelines neat, I leave no trace,
Just carrot-logs and a stable base. 🥕🚀

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch danielpanzella/fix-release-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)

52-55: Minor: pass IMG inline and harden the shell

Passing IMG directly to make avoids reliance on export, and adding strict mode plus quoting is safer.

Apply:

-      - name: Build and Push
-        run: |
-          export IMG=$IMAGE_TAG_BASE:$VERSION
-          make docker-build docker-push
+      - name: Build and Push
+        run: |
+          set -euo pipefail
+          make docker-build docker-push IMG="${IMAGE_TAG_BASE}:${VERSION}"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b53ca2 and 88d1df5.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test
  • GitHub Check: Build
🔇 Additional comments (1)
.github/workflows/release.yaml (1)

52-55: Explicit IMG export correctly overrides Makefile default — LGTM

Makefile defines IMG ?= controller:latest and references ${IMG} in docker-build, docker-push, and kustomize targets, so exporting IMG before make will override the default.

@zacharyblasczyk zacharyblasczyk merged commit 68a68f3 into main Sep 11, 2025
10 checks passed
@zacharyblasczyk zacharyblasczyk deleted the danielpanzella/fix-release-action branch September 11, 2025 20:02
jsbroks pushed a commit that referenced this pull request Sep 11, 2025
### [1.21.1](v1.21.0...v1.21.1) (2025-09-11)

### Bug Fixes

* Explicitly specify the desired value if IMG for make ([#99](#99)) ([68a68f3](68a68f3))
@jsbroks
Copy link
Copy Markdown
Member

jsbroks commented Sep 11, 2025

This PR is included in version 1.21.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants