fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception (brianc#3374)

andyjy · web-flow · commit 95bec690b327 · 2025-02-10T16:27:55.000-06:00
* fix(pg-pool): preserve original error on connection timeout, don't throw on readonly .message e.g. ErrorEvent Fixes brianc#3373 * Fix lint
diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js
@@ -244,7 +244,7 @@ class Pool extends EventEmitter {
         // remove the dead client from our list of clients
         this._clients = this._clients.filter((c) => c !== client)
         if (timeoutHit) {
-          err.message = 'Connection terminated due to connection timeout'
+          err = new Error('Connection terminated due to connection timeout', { cause: err })
         }
 
         // this client won’t be released, so move on immediately

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ class Pool extends EventEmitter {`
`244`	`244`	`// remove the dead client from our list of clients`
`245`	`245`	`this._clients = this._clients.filter((c) => c !== client)`
`246`	`246`	`if (timeoutHit) {`
`247`		`- err.message = 'Connection terminated due to connection timeout'`
	`247`	`+ err = new Error('Connection terminated due to connection timeout', { cause: err })`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`// this client won’t be released, so move on immediately`