Skip to content

Conversation

@samrushing
Copy link

@samrushing
Copy link
Author

Note: I just realized that there is already a modular square root function in the numbertheory module (square_root_mod_prime). Not sure what the pros and cons of the two implementations are, if I have time I'll try to see which is faster.

also: avoid unassigned variable bug.
@samrushing
Copy link
Author

Update: removed the redundant modular_sqrt fun.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c7157cc on samrushing:master into * on warner:master*.

@tomato42
Copy link
Member

tomato42 commented Sep 6, 2018

@samrushing I'm guessing that you consider this PR to be obsoleted by #54, is that correct?

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase necessary

@tomato42
Copy link
Member

tomato42 commented Oct 1, 2019

fixed by #118

@tomato42 tomato42 closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants