Add additional logs to wasp-bot
#61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranjoMindek
commented
Sep 24, 2025
| maxTimeout: 120 * 1000, | ||
| onRetry: (e: Error) => { | ||
| onRetry: (error: Error) => { | ||
| logger.error(error); |
Contributor
Author
There was a problem hiding this comment.
Since this will log the message with the stack trace, etc...
Martinsos
reviewed
Sep 24, 2025
Comment on lines
+22
to
+32
| logger.debug( | ||
| "\nNumber of non-Wasp-team CLI events:", | ||
| nonWaspTeamEvents.length, | ||
| ); | ||
|
|
||
| const sortedNonWaspTeamEvents = _.sortBy(nonWaspTeamEvents, "timestamp"); | ||
|
|
||
| const sortedValidEvents = markAsCiEventBurstsFromDifferentUsersFromSameIp( | ||
| sortedNonWaspTeamEvents, | ||
| ); | ||
| logger.debug("\nNumber of valid CLI events:", sortedValidEvents.length); |
Member
There was a problem hiding this comment.
Why do we care about these in our logging?
Contributor
Author
There was a problem hiding this comment.
I just wondered how much do these filters affect the data.
Not really necessary, it's debug logs.
Contributor
Author
There was a problem hiding this comment.
Also there might be betters ways to solve some of them I hope.
With time these become more costly (computation-wise).
Martinsos
approved these changes
Sep 24, 2025
Member
Martinsos
left a comment
Martinsos
left a comment
There was a problem hiding this comment.
All right! That is a lot of logging, it isn't obvious to me how some of these would be useful, but ok, if you think they are, let's go for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.