Skip to content

Conversation

@waszee
Copy link
Owner

@waszee waszee commented Sep 15, 2020

This is a learning exercise

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

Let's edit this pull request to add a body description.

⌨️ Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond when I detect this pull request's body has been edited.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 7: Respond to a review

Your pull request is looking great!

Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdown is supported.

⌨️ Activity: Change your file

  1. Click the Files Changed tab in this pull request
  2. Edit your newly added file
  3. Replace line 5 with something new
  4. Scroll to the bottom and click Commit Changes

Note : Can't find the button to edit the file? It may look like a pencil, or it may look like three dots.


I'll respond when I detect a commit on this branch.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Merge your pull request

Nicely done @waszee! ✨

You successfully created a pull request, and it has passed all of the tests. You can now merge your pull request.

⌨️ Activity: Merge the pull request

  1. Click Merge pull request

  2. Click Confirm merge

  3. Once your branch has been merged, you don't need it anymore. Click Delete branch.


I'll respond when this pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants