Fixed up Bitset #36
Merged
Fixed up Bitset #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mogball
force-pushed
the
jeff/bitset_fixes
branch
from
f33164e to
a3ccd46
Compare
Mogball
force-pushed
the
jeff/bitset_fixes
branch
from
a3ccd46 to
83e5d49
Compare
dhillondeep
reviewed
Nov 6, 2017
lib/wlib/stl/Bitset.h
Outdated
| * Integer type arrays generally have the fastest access | ||
| * times in C++. | ||
| */ | ||
| int m_array[ceil_bits<nBits>::value]; |
Contributor
There was a problem hiding this comment.
you should use uint32_t instead of int because int size is system dependent and I believe for to_uint32 you want it to be 32 bits
Mogball
force-pushed
the
jeff/bitset_fixes
branch
2 times, most recently
from
bf2451e to
06d7df0
Compare
Mogball
force-pushed
the
jeff/bitset_fixes
branch
from
06d7df0 to
57eae05
Compare
Closed
dhillondeep
pushed a commit
that referenced
this pull request
May 26, 2020
* Fixed up Bitset * code review changes * cast changed from int to uint32_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.