[Lib] State Machine + [HF] memory fixes #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
it seems like it has segmentation faults |
dhillondeep
reviewed
Nov 20, 2017
lib/wlib/fsm/StateMachine.cpp
Outdated
| free<EventData>(pData); | ||
| } | ||
| } else { | ||
| // TODO - capture software lock here for thread-safety if necessary |
Contributor
There was a problem hiding this comment.
we will be on single thread so don't worry about the lock
dhillondeep
reviewed
Nov 20, 2017
tests/fsm/fsm_check.cpp
Outdated
| } | ||
|
|
||
| void setValue(int value) { | ||
| TestData* data = new TestData(); |
Contributor
There was a problem hiding this comment.
Where do you free this?
dhillondeep
approved these changes
Nov 21, 2017
dhillondeep
pushed a commit
that referenced
this pull request
May 26, 2020
* Created state machine class and defn * f * object size is stored to free them properly * Removed dynamic event data allocation * Updated with master * memory test fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
redo with new memory stuff once that's mergedremove inheritance because it's causing trouble with the memory stuff