add new setting term:macoptionismeta

[sawka]

No description provided.

[coderabbitai]

Walkthrough

Adds a new configuration key term:macoptionismeta (boolean) across the stack to treat the macOS Option key as Meta for terminal keybindings. Changes touch documentation, JSON schema, TypeScript types, frontend atom wiring and TermWrap props, backend config constants and Settings struct, and waveobj meta constants/struct. Also removes an unused InitialLoadDataType in the terminal view and updates frontend state handling to read the new override atom.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Multiple layers affected but changes are homogeneous (new config key propagated).
• Review attention points:
  • Verify term:macoptionismeta is declared consistently in Go constants, SettingsType, schema, TypeScript defs, and waveobj meta.
  • Confirm frontend atom (termMacOptionIsMetaAtom / termMacOptionIsMeta) reads globalStore correctly and defaults to false.
  • Ensure macOptionIsMeta is passed into TermWrap and used as intended.
  • Check the removal of InitialLoadDataType in term.tsx does not break initialization paths.
  • Review substantial doc updates in aiprompts/config-system.md for accuracy and intended workflow changes.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the purpose of the new setting, its behavior, and any relevant context for reviewers.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a new configuration setting 'term:macoptionismeta' that allows treating the Option key as Meta key on macOS.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sawka/mac-option-is-meta

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fc17df and 980b162.

📒 Files selected for processing (4)

• aiprompts/config-system.md (6 hunks)
• frontend/types/gotypes.d.ts (2 hunks)
• pkg/waveobj/metaconsts.go (1 hunks)
• pkg/waveobj/wtypemeta.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• frontend/types/gotypes.d.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (go)
• GitHub Check: Build for TestDriver.ai

🔇 Additional comments (4)

pkg/waveobj/metaconsts.go (1)

117-117: LGTM! Constant addition is correct.

The new constant MetaKey_TermMacOptionIsMeta is properly named, correctly placed within the term-related keys section, and uses the expected lowercase-with-colons format for the value.

pkg/waveobj/wtypemeta.go (1)

121-121: LGTM! Field addition is correct.

The TermMacOptionIsMeta field is properly typed as *bool for optional block-level overrides, uses the correct JSON tag that matches the meta key constant, and is placed consistently with the ordering in metaconsts.go.

aiprompts/config-system.md (2)

155-209: LGTM! Documentation improvements are clear and helpful.

The workflow documentation has been updated to reflect the modern auto-generation process. Key improvements include:

• Logical reordering of steps (defaults → documentation → generation)
• Clear emphasis that JSON schema is auto-generated from Go structs
• Consolidated task generate command that handles schema, TypeScript types, RPC APIs, and metadata constants
• Removal of outdated manual JSON schema editing instructions

These changes make the contribution process clearer and prevent contributors from manually editing generated files.

---

299-337: LGTM! Example section updates match the new workflow.

The complete example for adding term:bellsound has been updated to:

• Match the new step numbering and ordering
• Include helpful clarifications (file paths, optional status)
• Use the consolidated task generate command
• Reflect the current auto-generation workflow

The example remains clear and easy to follow for contributors.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}