Skip to content

Conversation

@sawka
Copy link
Member

@sawka sawka commented Nov 21, 2025

also stop sending OLD telemetry events (new tevents still sent)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates Wave to v0.12.4. Changes include: added release notes for v0.12.4; bumped onboarding/version constants from v0.12.3 to v0.12.4 in frontend onboarding files; updated DefaultTsunamiSdkVersion and TsunamiSdkVersion constants to v0.12.4; added a Windows-specific early return in unameKernelRelease to avoid running uname -r on Windows; and modified SendAllTelemetry in pkg/wcloud to process and log TEvents without forwarding to the previous sendTelemetry path (removing the activity-send forwarding).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • pkg/wcloud/wcloud.go — review behavioral impact of removing the forwarding to sendTelemetry (activity transmission, error propagation, telemetry completeness).
  • pkg/wavebase/wavebase.go — confirm returning "-" on Windows is the intended behavior for kernel-release reporting.
  • frontend onboarding files (onboarding-common.tsx, onboarding-upgrade-patch.tsx) — verify version bumps are consistent and won't break upgrade flows.
  • tsunami/cmd/main-tsunami.go and pkg/waveapputil/waveapputil.go — verify SDK/version constant updates align with release artifacts and build configuration.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'v0.12.4 release notes' directly relates to the primary changeset, which adds release notes documentation for v0.12.4.
Description check ✅ Passed The description mentions stopping OLD telemetry events while keeping new ones sent, which aligns with the pkg/wcloud/wcloud.go changes that modify SendAllTelemetry behavior.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c59caa5 and 6a00211.

📒 Files selected for processing (2)
  • pkg/waveapputil/waveapputil.go (1 hunks)
  • tsunami/cmd/main-tsunami.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawka sawka merged commit f621e61 into main Nov 22, 2025
6 of 7 checks passed
@sawka sawka deleted the sawka/rl-124 branch November 22, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants