Skip to content

Conversation

@sawka
Copy link
Member

@sawka sawka commented Nov 22, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025

Walkthrough

This pull request removes Storybook from the project entirely. The changes include deletion of all Storybook configuration files (.storybook directory), removal of 11 UI component story files, elimination of Storybook scripts and dependencies from package.json, and updates to GitHub workflows, documentation, and build configuration (Taskfile.yml) to reference only the docsite. Additionally, two optional telemetry fields are added to the frontend types, and minor CSS cleanup is performed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Multiple story file deletions: Review completeness of removal across 11 story files (button, emojipalette, expandablemenu, flyoutmenu, input, magnify, menubutton, multilineinput, popover, progressbar, search) to ensure consistency
  • Workflow configuration changes: Verify the updated GitHub workflow correctly references only docsite paths and triggers appropriately
  • Dependency removal: Ensure all Storybook-related packages are removed from package.json and that no transitive dependencies cause issues
  • Build configuration: Confirm Taskfile.yml changes properly remove all Storybook build steps and that docsite:build still functions without them
  • Telemetry type additions: Verify the new "waveai:chatid" and "waveai:stepnum" fields in TEventProps are compatible with existing telemetry logic and won't cause runtime conflicts

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the rationale for removing Storybook and any migration guidance or breaking changes for developers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately and concisely summarizes the main change: removing Storybook, related tasks, and dependencies from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/remove-storybook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/types/gotypes.d.ts (1)

1223-1224: Verify that these telemetry field additions belong in this PR.

These changes add new WaveAI telemetry fields, which appears unrelated to the PR's main objective of removing Storybook. If these are intentional additions needed for separate functionality, consider whether they should be in a separate PR for clearer change tracking.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99a2576 and dd91556.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (24)
  • .github/workflows/deploy-docsite.yml (2 hunks)
  • .storybook/custom-addons/theme/register.ts (0 hunks)
  • .storybook/global.css (0 hunks)
  • .storybook/main.ts (0 hunks)
  • .storybook/preview.tsx (0 hunks)
  • .storybook/theme.ts (0 hunks)
  • CONTRIBUTING.md (0 hunks)
  • README.md (0 hunks)
  • Taskfile.yml (0 hunks)
  • docs/README.md (1 hunks)
  • frontend/app/element/button.stories.tsx (0 hunks)
  • frontend/app/element/emojipalette.stories.tsx (0 hunks)
  • frontend/app/element/expandablemenu.stories.tsx (0 hunks)
  • frontend/app/element/flyoutmenu.stories.tsx (0 hunks)
  • frontend/app/element/input.stories.tsx (0 hunks)
  • frontend/app/element/magnify.stories.tsx (0 hunks)
  • frontend/app/element/menubutton.stories.tsx (0 hunks)
  • frontend/app/element/multilineinput.stories.tsx (0 hunks)
  • frontend/app/element/popover.stories.tsx (0 hunks)
  • frontend/app/element/progressbar.stories.tsx (0 hunks)
  • frontend/app/element/search.stories.tsx (0 hunks)
  • frontend/layout/lib/tilelayout.stories.scss (0 hunks)
  • frontend/types/gotypes.d.ts (1 hunks)
  • package.json (0 hunks)
💤 Files with no reviewable changes (21)
  • CONTRIBUTING.md
  • .storybook/theme.ts
  • frontend/app/element/popover.stories.tsx
  • Taskfile.yml
  • README.md
  • frontend/app/element/magnify.stories.tsx
  • frontend/app/element/multilineinput.stories.tsx
  • .storybook/custom-addons/theme/register.ts
  • frontend/app/element/input.stories.tsx
  • frontend/app/element/menubutton.stories.tsx
  • frontend/app/element/search.stories.tsx
  • frontend/app/element/expandablemenu.stories.tsx
  • frontend/app/element/emojipalette.stories.tsx
  • .storybook/preview.tsx
  • frontend/app/element/progressbar.stories.tsx
  • .storybook/main.ts
  • frontend/layout/lib/tilelayout.stories.scss
  • frontend/app/element/button.stories.tsx
  • package.json
  • .storybook/global.css
  • frontend/app/element/flyoutmenu.stories.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Build Docsite
  • GitHub Check: Build for TestDriver.ai
  • GitHub Check: merge-gatekeeper
🔇 Additional comments (6)
docs/README.md (2)

20-20: ✓ Build command correctly references the public build target.

The command now points to a specific, actionable task. This is an improvement over a placeholder parameter.


27-27: ✓ Deployment reference properly updated to reflect workflow rename.

The link correctly points to the renamed workflow file in line with the removal of Storybook tooling.

.github/workflows/deploy-docsite.yml (3)

1-3: ✓ Workflow metadata correctly simplified to reference Docsite only.

The name and run-name updates cleanly reflect the removal of Storybook tooling from this workflow.


13-25: ✓ PR trigger paths correctly scoped to documentation and build configuration.

The path filtering appropriately:

  • Triggers on all documentation changes (docs/**)
  • Triggers on workflow changes (.github/workflows/deploy-docsite.yml)
  • Triggers on task definition changes (Taskfile.yml)

This ensures CI runs for relevant config updates while avoiding spurious runs.


53-54: ✓ Build step correctly references the docsite build task.

Consistent with the command documented in docs/README.md and aligns with the removal of Storybook build steps.

frontend/types/gotypes.d.ts (1)

4-4: The review comment is incorrect—these are properly generated fields, not manual edits.

The fields "waveai:chatid" and "waveai:stepnum" at lines 1223-1224 are correctly generated from Go struct definitions in pkg/telemetry/telemetrydata/telemetrydata.go (lines 130-131). The generator automatically converts Go struct fields with json tags into TypeScript optional properties. This is the expected and correct output of the generator, not a manual modification to a generated file.

Likely an incorrect or invalid review comment.

@sawka sawka merged commit 1f48356 into main Nov 24, 2025
9 checks passed
@sawka sawka deleted the sawka/remove-storybook branch November 24, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants