Skip to content

refactor: bindings and tests #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 2, 2023
Merged

refactor: bindings and tests #117

merged 20 commits into from
May 2, 2023

Conversation

@lotyp
Copy link
Member

@lotyp lotyp commented Apr 30, 2023

No description provided.

@github-actions github-actions bot added the type: maintenance For maintenance, refactor and testing (perf, chore, style, revert, refactor, test, build, ci) label Apr 30, 2023
nevmerzhitsky
nevmerzhitsky reviewed May 1, 2023
View reviewed changes
config/cycle.php Outdated

'pgsql' => new Config\PostgresDriverConfig(
connection: new Config\Postgres\TcpConnectionConfig(
database: env('DB_NAME', 'wod'),
Copy link

@nevmerzhitsky nevmerzhitsky May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laravel uses the DB_DATABASE env var for this purpose.

@lotyp
Copy link
Member Author

lotyp commented May 2, 2023

Currently trying to solve this:

There were 40 errors:
[60](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:62)

[61](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:63)
1) WayOfDev\Tests\Bridge\Laravel\Console\Commands\Database\ListCommandTest::it_runs_handle
[62](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:64)
Error: Undefined constant PDO::MYSQL_ATTR_INIT_COMMAND
[63](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:65)

[64](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:66)
/app/vendor/cycle/database/src/Config/MySQL/ConnectionConfig.php:30
[65](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:67)
/app/vendor/laravel/framework/src/Illuminate/Support/ServiceProvider.php:138
[66](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:68)
/app/src/Bridge/Laravel/Providers/CycleServiceProvider.php:27
[67](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:69)
/app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:764
[68](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:70)
/app/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:75
[69](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:71)
/app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:741
[70](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:72)
/app/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/RegisterProviders.php:17
[71](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:73)
/app/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:347
[72](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:74)
/app/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:230
[73](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:75)
/app/vendor/orchestra/testbench-core/src/TestCase.php:120
[74](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:76)
/app/vendor/orchestra/testbench-core/src/Concerns/Testing.php:87
[75](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:77)
/app/vendor/orchestra/testbench-core/src/TestCase.php:51
[76](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:78)
/app/tests/src/TestCase.php:37
[77](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:79)

[78](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:80)
2) WayOfDev\Tests\Bridge\Laravel\Console\Commands\Database\TableCommandTest::it_runs_handle
[79](https://github.com/wayofdev/laravel-cycle-orm-adapter/actions/runs/4845564836/jobs/8634553025?pr=117#step:7:81)
Error: Undefined constant PDO::MYSQL_ATTR_INIT_COMMAND

@lotyp lotyp merged commit d5cb156 into master May 2, 2023
@lotyp lotyp deleted the feat/mvp branch May 2, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nevmerzhitsky nevmerzhitsky nevmerzhitsky left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: maintenance For maintenance, refactor and testing (perf, chore, style, revert, refactor, test, build, ci)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lotyp @nevmerzhitsky