Conversation
Not adding this can cause compilation failures when the bundled versions of libraries (like Ghostscript) don't match the system-provided ones. Note that this commit only is checked with downloaded and self-compiled versions on Linux. I assume distro packages will work as well (or don't need it anyway), but I have no idea about Mac and Win.
Contributor
Author
|
There's one thing I'm not really sure about, and that's who |
Contributor
Author
|
See also http://lists.gnu.org/archive/html/lilypond-user/2017-04/msg00236.html for the question of other OS/installation types |
Contributor
Author
|
It seems the issue is no issue on Windows as probably all dependencies are bundled in the installer. So that leaves OS X. I don't know how LilyPond is packaged/bundled there, but somehow I have the feeling it's bundled as well. As I don't recall this error being raised by non-Linux users I think we can merge this patch and wait if any users raise the issue again. |
uliska
changed the title
Contributor
Author
|
As I haven't got any further feedback I assume that
So I'll merge this after fixing the indicated merge conflicts |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix a long-standing annoyance - but is only implemented with downloaded and self-compiled versions on Linux. I assume distro packages will work as well (or don't need it anyway), but I have no idea about Mac and Win. Maybe the problem doesn't apply to them, but I want to wait for feedback on that before merging this PR.
Not adding this can cause compilation failures when the bundled versions of libraries (like Ghostscript) don't match the system-provided ones.