Skip to content

Replace laravel-stackdriver package #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Replace laravel-stackdriver package #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7d26212
remove `gluedev/laravel-stackdriver`
deer-wmde Jan 26, 2024
74ba771
add `google/cloud-error-reporting`
deer-wmde Jan 26, 2024
bc6f9b7
refactor exception handler
deer-wmde Jan 26, 2024
1a4fb44
add debug output for testing
deer-wmde Jan 26, 2024
9a4aaaf
debug testing
deer-wmde Jan 26, 2024
cd6dfb8
debug
deer-wmde Jan 26, 2024
efd1a61
wip
deer-wmde Jan 26, 2024
f7e2f25
use Error Reporting API
deer-wmde Jan 26, 2024
6076faa
add new stackdriver package
deer-wmde Jan 29, 2024
bfad466
configure new stackdriver package
deer-wmde Jan 29, 2024
c35d9e6
Add `logName` to conf
deer-wmde Jan 31, 2024
cb37db5
fix env var name
deer-wmde Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions app/Exceptions/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace App\Exceptions;

use GlueDev\Laravel\Stackdriver\StackdriverExceptionHandler;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Throwable;

Expand Down Expand Up @@ -36,14 +35,12 @@ class Handler extends ExceptionHandler
];

/**
* Report or log an exception.
*
* @param \Throwable $e
* @return void
* Register the exception handling callbacks for the application.
*/
public function report(Throwable $e)
public function register()
Copy link
Contributor

@tarrow tarrow Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this; we just wanted to check that this will behave in the same way as before but is the new recommended way to do this.

Copy link
Contributor Author

@deer-wmde deer-wmde Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the docs this seems to be recommended, although I now realized a reason to override the report function may be if you want to call it yourself when there is no Exception (see section The report helper)

Copy link
Contributor Author

@deer-wmde deer-wmde Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do this anywhere though. edit: not true, there are in fact 3 occurences of this in our code.

Copy link
Contributor Author

@deer-wmde deer-wmde Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I have to correct myself again, after testing locally I could verify that the handler still gets called this way, so we should be good.

Copy link
Contributor

@tarrow tarrow Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, this is excellent

{
StackdriverExceptionHandler::report($e);
parent::report($e);
$this->reportable(function (Throwable $e) {
(new \Absszero\ErrorReporting)->report($e);
});
}
}
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"license": "MIT",
"type": "project",
"require": {
"absszero/laravel-stackdriver-error-reporting": "^1.7",
"cviebrock/eloquent-sluggable": "^9.0",
"doctrine/dbal": "^3.1",
"firebase/php-jwt": "^5.4",
"fruitcake/laravel-cors": "^2.0",
"gluedev/laravel-stackdriver": "dev-develop#7fb3e78ce949dd341b5418f876c3ff74d8c1ff92",
"google/recaptcha": "^1.2",
"guzzlehttp/guzzle": "^7.8",
"guzzlehttp/psr7": "^1.9",
Expand Down
Loading