Added allocator to dl_util functions. #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dl_util functions were changed to use the internal allocator. The should not be using the internal allocator since that one is dedicated to be used to the type library. Unfortunately there are conditions as to when the allocations are actually done, so we can't use one temp for the file allocations and one for the instance allocations, since they are sometimes the same. This is to solve issue #90.
wc-duck
reviewed
Aug 20, 2018
Owner
wc-duck
left a comment
wc-duck
left a comment
There was a problem hiding this comment.
If the above comments are fixed I'll merge this right away.
include/dl/dl_util.h
Outdated
| filetype - Type of file to read, see dl_util_file_type_t. | ||
| out_instance - Pointer to fill with read instance. | ||
| out_type - TypeID of instance found in file, can be set to 0x0. | ||
| allocator - Allocator for doing temp file allocations |
Owner
There was a problem hiding this comment.
... and allocating the out-instance!
include/dl/dl_util.h
Outdated
| const char* filename, dl_util_file_type_t filetype, | ||
| void** out_instance, dl_typeid_t* out_type ); | ||
| void** out_instance, dl_typeid_t* out_type, | ||
| dl_allocator *allocator = 0x0 ); |
Owner
There was a problem hiding this comment.
I would like to keep default-values out of the interface as this breaks c-compat.
Owner
There was a problem hiding this comment.
This also need doc that says that 0 is valid an what that means.
Collaborator
Author
There was a problem hiding this comment.
Ait! I will remove default-value and say that 0 is valid!
wc-duck
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dl_util functions were changed to use the internal allocator. The should not be using the internal allocator since that one is dedicated to be used to the type library. Unfortunately there are conditions as to when the allocations are actually done, so we can't use one temp for the file allocations and one for the instance allocations, since they are sometimes the same. This is to solve issue #90.