Skip to content

add support for eu-west-1#189

Merged
richardcase merged 1 commit into
eksctl-io:gpu-support-183from
mseiwald:master
Sep 7, 2018
Merged

add support for eu-west-1#189
richardcase merged 1 commit into
eksctl-io:gpu-support-183from
mseiwald:master

Conversation

@mseiwald
Copy link
Copy Markdown

@mseiwald mseiwald commented Sep 6, 2018

Description

add support for eu-west-1

Copy link
Copy Markdown
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
As the number of EKS enabled regions increases we will probably want to refactor this code.

Copy link
Copy Markdown
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! However, I am pretty certain the AMI in Ireland is of different version then other two, could you please update the other two AMIs? (see #49 (comment) for a handy command).

@errordeveloper
Copy link
Copy Markdown
Contributor

errordeveloper commented Sep 6, 2018

The new AMI no longer uses heptio-aws-authenticator, so you will need to change this:
https://github.com/weaveworks/eksctl/blob/232006f0e4ac6ae47b09f10e1c365bf7093b4439/pkg/nodebootstrap/assets/authenticator.sh#L8
You want to use aws-iam-authenticator instead. To reflect these change you will need to run make generate and check in the results.

@richardcase
Copy link
Copy Markdown
Contributor

richardcase commented Sep 7, 2018

I am pretty certain the AMI in Ireland is of different version then other two, could you please update the other two AMIs?

For reference I've updated them in the change i'm making:

https://github.com/weaveworks/eksctl/blob/a01239a43996045ff15ea94419d6f5c4b6dad500/pkg/ami/ami.go#L40

@richardcase
Copy link
Copy Markdown
Contributor

@errordeveloper @mseiwald - whall i merge this PR into my branch for #192?

@errordeveloper
Copy link
Copy Markdown
Contributor

errordeveloper commented Sep 7, 2018 via email

@richardcase richardcase changed the base branch from master to gpu-support-183 September 7, 2018 14:54
@richardcase richardcase merged commit b298750 into eksctl-io:gpu-support-183 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants