Skip to content

Fix nameLabelValue when waiting for helm-operator#2117

Merged
martina-if merged 2 commits into
eksctl-io:masterfrom
greg-cook:fix-helm-operator-wait-label
May 6, 2020
Merged

Fix nameLabelValue when waiting for helm-operator#2117
martina-if merged 2 commits into
eksctl-io:masterfrom
greg-cook:fix-helm-operator-wait-label

Conversation

@greg-cook
Copy link
Copy Markdown
Contributor

@greg-cook greg-cook commented May 1, 2020 •
edited
Loading

Description

fluxcd/helm-operator#322 updated the name of the
helm-operator deployment. This updates the nameLabelValue so deployment
is detected successfully.

Old name: flux-helm-operator
New name: helm-operator

Error when running eksctl enable repo

EKSCTL_EXPERIMENTAL=true eksctl enable repo --cluster=<redacted> --region=ap-southeast-2 --git-url=git@github.com:<redacted>.git --git-email=<redacted>
[ℹ]  Generating manifests
[ℹ]  Cloning git@github.com:<redacted>.git
Cloning into '<redacted>'...
remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
Receiving objects: 100% (3/3), done.
Already on 'master'
Your branch is up to date with 'origin/master'.
[ℹ]  Writing Flux manifests
[ℹ]  created "Namespace/flux"
[ℹ]  Applying manifests
[ℹ]  created "flux:Deployment.apps/flux"
[ℹ]  created "flux:Deployment.apps/helm-operator"
[ℹ]  created "flux:ServiceAccount/helm-operator"
[ℹ]  created "ClusterRole.rbac.authorization.k8s.io/helm-operator"
[ℹ]  created "ClusterRoleBinding.rbac.authorization.k8s.io/helm-operator"
[ℹ]  created "flux:ServiceAccount/flux"
[ℹ]  created "ClusterRole.rbac.authorization.k8s.io/flux"
[ℹ]  created "ClusterRoleBinding.rbac.authorization.k8s.io/flux"
[ℹ]  created "flux:Service/memcached"
[ℹ]  created "flux:Secret/flux-git-deploy"
[ℹ]  created "CustomResourceDefinition.apiextensions.k8s.io/helmreleases.helm.fluxcd.io"
[ℹ]  created "flux:Deployment.apps/memcached"
[ℹ]  Waiting for Helm Operator to start
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[!]  Helm Operator is not ready yet (Could not create a dialer: Could not get pod name: Could not find pod for selector: labels "name in (flux-helm-operator)"), retrying ...
[✖]  You may find the local clone of git@github.com:<redacted>.git used by eksctl at <redacted>
[ℹ]
Error: timed out waiting for Helm Operator's pod to be created

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@sayboras sayboras mentioned this pull request May 1, 2020
Closed
@sayboras
Copy link
Copy Markdown
Contributor

sayboras commented May 1, 2020

Nice, this might fix 2 daily integration test failures as well :)

@marclamberti
Copy link
Copy Markdown

marclamberti commented May 2, 2020

Not yet merged in the 0.19.0 ? :'(

martina-if
martina-if previously approved these changes May 4, 2020
View reviewed changes
@martina-if
Copy link
Copy Markdown
Contributor

martina-if commented May 4, 2020

Hi @greg-cook , thank you so much for this fix! Can you please rebase your branch on top of master so that we can merge it?

@martina-if martina-if added the priority/critical Should be investigated as soon as possible label May 4, 2020
@martina-if martina-if dismissed their stale review May 4, 2020 13:46

Actually, this needs more changes. We need to fix the integration tests as well.

martina-if
martina-if suggested changes May 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@martina-if martina-if left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I need to dismiss my previous review (but the button doesn't work at the moment). We need to fix the integration tests as well. You can see how in #2133.

@martina-if martina-if mentioned this pull request May 4, 2020
Merged
4 tasks
greg-cook added 2 commits May 6, 2020 09:32
@greg-cook
Fix nameLabelValue when waiting for helm-operator
34142fc 
fluxcd/helm-operator#322 updated the name of the
helm-operator deployment. This updates the nameLabelValue so deployment
is detected successfully.

Old name: `flux-helm-operator`
New name: `helm-operator`
@greg-cook
update integration tests for helm-operator pod name
8f39d48
@greg-cook
Copy link
Copy Markdown
Contributor Author

greg-cook commented May 5, 2020

@martina-if Done!

@greg-cook greg-cook requested a review from martina-if May 5, 2020 23:33
@martina-if martina-if merged commit d819591 into eksctl-io:master May 6, 2020
@greg-cook greg-cook deleted the fix-helm-operator-wait-label branch May 12, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martina-if martina-if martina-if approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/bug priority/critical Should be investigated as soon as possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greg-cook @sayboras @marclamberti @martina-if