Complete Collections interface enhancements #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
mpartipilo
force-pushed
the
feat/collection_completeness_1
branch
from
edd1d26 to
263ea31
Compare
dirkkul
reviewed
Jun 20, 2025
dirkkul
approved these changes
Jun 24, 2025
dirkkul
reviewed
Jun 24, 2025
| public int ActualVirtualCount { get; set; } = 128; | ||
| public string Key { get; set; } = "_id"; | ||
| public string Strategy { get; set; } = "hash"; | ||
| public string Function { get; set; } = "murmur3"; |
Collaborator
There was a problem hiding this comment.
I'd remove the default values, we try to not have default values in the clients so we don't need to change stuff in all clients when a value in the server changes.
Also (and this might not make sense in c#) we should have different structures for input and output - input can all be optional and should be none by default, while the output should have the concrete type
Collaborator
Author
There was a problem hiding this comment.
Let's do this as part of this: https://www.notion.so/weaviate/Ux-review-20e70562ccd680e8a2bbc71f29144714?source=copy_link#21c70562ccd68078a5c2eca4d554b622
dirkkul
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the Collections interface by adding methods for deleting all collections, checking existence, and exporting collections. Include the System.Linq.Async package for improved asynchronous operations.