feat: add 'groups' namespace #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
These are server-specific and have nothing to do with the client logic
This test simply checks that server returns some string exactly, which is based _entirely_ on how the server is configured and has no relation to the client-side logic. It is deserialized in and Object, so there is no special behavior to verify. The assertion does fail with v1.33.0-rc.0 though, because the server started returning a different string. Once again, this string is not something that affects client behavior in any way.
|
I deleted one of the failing tests case, see d8e8ba4 for the reasoning behind it. |
|
Weaviate v1.33 appears to have a regression in the Explorer API that's causing the related tests to fail. There are no plans to fix the regression. https://weaviate-org.slack.com/archives/C05TV6AP8P3/p1756910684886959 |
They are breaking due to a regression in Weaviate v1.33.
dirkkul
approved these changes
Sep 9, 2025
| return this; | ||
| } | ||
|
|
||
| private String _groupId() { |
There was a problem hiding this comment.
I would change the name just getGroupId or groupId having an _ in method naming feels like Python / Rust code
There was a problem hiding this comment.
Renamed in all files
antas-marcin
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new
groupsnamespace for assigning / revoking roles to user groups rather than individual users. The API is similar to that inusersnamespace:Complimenting that are GroupsPermissions which a role can now have: