-
Couldn't load subscription status.
- Fork 22
v6: Implement users' feedback #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
293c0ef to
5a0cc09
Compare
…default vector config" This reverts commit b721a52.
…der the new namespace
Rename vectors -> vectorConfig
1) Ping /live endpoint once we have the RestTransport but before the client is fully initialized. If the instance is not reachable, close the existing resouces and throw a WeaviateConnectException. The user can catch that earlier in their application, e.g. at startup, not when they send the first request. 2) Renamed connection helper methods: - local -> connectToLocal - wcd -> connectToWeaviateCloud - custom -> connectToCustom
d722fa1 to
cab1067
Compare
|
Hey @bevzzz this is all great 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference property static factory
Improved String representation of Vectors
Renamed connection helpers + liveness check
If the instance does not respond to a liveness check (
GET /live) the constructor (and the helper factories) will throw an exception and dispose of any resources obtained thus far (HTTP client).The examples show WeaviateClient, but the same is of course true for WeaviateAsyncClient.
Local configuration parameters
VectorConfig
Quantization
Max gRPC message size
The client now fetches server's metadata at startup and sets an inbound/outbound
grpc_max_message_sizeto match the value configured on the server.