-
Couldn't load subscription status.
- Fork 22
v6: Generative queries + Dynamic RAG #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
- Mistral - Anyscale - Databricks
- Anthropic - AWS - Azure / OpenAI - Friendliai - Google - Nvidia - Ollama - Xai
Azure Databricks Friendliai Google Mistral Nvidia Ollama OpenAI XAI
| * | ||
| * @param fn Lambda expression for optional parameters. | ||
| */ | ||
| public static DynamicProvider aws( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DId you think about using separate factories for sagemaker and bedrock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did but after looking through the docs ("Ask AI") I figured it was only 1 argument each that is special to the service (sagemaker -> endpoint, bedrock -> model).
Providing separate builders for each is not too much work, but I'm leaning towards documenting that in the Javadoc. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is not much work, I'd prefer the separate builders
But no strong opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change in a follow-up PR, to avoid tricky rebases and such.
If everything else is fine, I'll proceed with merging this.
Here's an example showcasing the new functionality.
This PR provides support for all generative modules we currently have in Weaviate:
DummyGenerative, while defined, is not "advertised" via the static factories in
GenerativeandDynamicProviderclasses.