Skip to content

Conversation

@augustas1
Copy link
Contributor

@augustas1 augustas1 commented Oct 22, 2025

Introducing multi2multivec-weaviate vectorizer.
Accepts only 1 image field when configuring vectorizer.

Module PR: weaviate/weaviate#9520

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (bdc6481) to head (eea40b3).
⚠️ Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/collections/classes/config_vectorizers.py 60.00% 4 Missing ⚠️
weaviate/collections/classes/config_vectors.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   86.80%   86.71%   -0.10%     
==========================================
  Files         273      273              
  Lines       19059    19695     +636     
==========================================
+ Hits        16544    17078     +534     
- Misses       2515     2617     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@augustas1 augustas1 force-pushed the multi2multivec-weaviate branch from 5387c83 to 0ab89a2 Compare November 18, 2025 09:46
Copy link
Collaborator

@dirkkul dirkkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test under test/collection/test_config.py?

encoding: Optional[_MultiVectorEncodingConfigCreate] = None,
quantizer: Optional[_QuantizerConfigCreate] = None,
base_url: Optional[AnyHttpUrl] = None,
model: Optional[Union[JinaMultimodalModel, str]] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong model typing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants