Skip to content

feat: add nullable request parameter to creation and request options handlers #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

feat: add nullable request parameter to creation and request options handlers #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 156 additions & 0 deletions .ci-tools/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,6 +1767,30 @@ parameters:
count: 1
path: ../src/symfony/src/Security/Authorization/Voter/IsUserVerifiedVoter.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\CreationOptionsHandler::onCreationOptions() has parameter $request with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/CreationOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\CreationOptionsHandler::onCreationOptions() has parameter $request with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/CreationOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultCreationOptionsHandler::onCreationOptions() has parameter $request with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/DefaultCreationOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultCreationOptionsHandler::onCreationOptions() has parameter $request with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/DefaultCreationOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultFailureHandler::onFailure() has parameter $exception with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
Expand All @@ -1779,12 +1803,60 @@ parameters:
count: 1
path: ../src/symfony/src/Security/Handler/DefaultFailureHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultRequestOptionsHandler::onRequestOptions() has parameter $request with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/DefaultRequestOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultRequestOptionsHandler::onRequestOptions() has parameter $request with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/DefaultRequestOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultRequestOptionsHandler::onRequestOptions() has parameter $userEntity with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/DefaultRequestOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredential with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredential with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredentialOptions with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredentialOptions with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultSuccessHandler::onSuccess() has parameter $userEntity with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\DefaultSuccessHandler::onSuccess() has parameter $userEntity with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\FailureHandler::onFailure() has parameter $exception with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
Expand All @@ -1797,12 +1869,60 @@ parameters:
count: 1
path: ../src/symfony/src/Security/Handler/FailureHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\RequestOptionsHandler::onRequestOptions() has parameter $request with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/RequestOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\RequestOptionsHandler::onRequestOptions() has parameter $request with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/RequestOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\RequestOptionsHandler::onRequestOptions() has parameter $userEntity with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/RequestOptionsHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\SuccessHandler::onSuccess() has parameter $publicKeyCredential with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/SuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\SuccessHandler::onSuccess() has parameter $publicKeyCredential with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/SuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\SuccessHandler::onSuccess() has parameter $publicKeyCredentialOptions with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/SuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\SuccessHandler::onSuccess() has parameter $publicKeyCredentialOptions with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/SuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\SuccessHandler::onSuccess() has parameter $userEntity with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Security/Handler/SuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Security\Handler\SuccessHandler::onSuccess() has parameter $userEntity with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Security/Handler/SuccessHandler.php

-
rawMessage: Class Webauthn\Bundle\Security\Http\Authenticator\Passport\Credentials\WebauthnCredentials is neither abstract nor final.
identifier: ergebnis.final
Expand Down Expand Up @@ -2082,6 +2202,42 @@ parameters:
count: 1
path: ../src/symfony/src/Service/DefaultFailureHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Service\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredential with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Service/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Service\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredential with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Service/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Service\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredentialOptions with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Service/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Service\DefaultSuccessHandler::onSuccess() has parameter $publicKeyCredentialOptions with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Service/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Service\DefaultSuccessHandler::onSuccess() has parameter $userEntity with a nullable type declaration.'
identifier: ergebnis.noParameterWithNullableTypeDeclaration
count: 1
path: ../src/symfony/src/Service/DefaultSuccessHandler.php

-
rawMessage: 'Method Webauthn\Bundle\Service\DefaultSuccessHandler::onSuccess() has parameter $userEntity with null as default value.'
identifier: ergebnis.noParameterWithNullDefaultValue
count: 1
path: ../src/symfony/src/Service/DefaultSuccessHandler.php

-
rawMessage: Cannot access offset 'attestation_conveyance' on mixed.
identifier: offsetAccess.nonOffsetAccessible
Expand Down
4 changes: 3 additions & 1 deletion src/symfony/src/Security/Handler/CreationOptionsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Webauthn\Bundle\Security\Handler;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Webauthn\PublicKeyCredentialCreationOptions;
use Webauthn\PublicKeyCredentialUserEntity;
Expand All @@ -12,6 +13,7 @@ interface CreationOptionsHandler
{
public function onCreationOptions(
PublicKeyCredentialCreationOptions $publicKeyCredentialCreationOptions,
PublicKeyCredentialUserEntity $userEntity
PublicKeyCredentialUserEntity $userEntity,
?Request $request = null,
): Response;
}
4 changes: 3 additions & 1 deletion src/symfony/src/Security/Handler/DefaultCreationOptionsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use RuntimeException;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\Encoder\JsonEncoder;
use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
Expand All @@ -23,7 +24,8 @@ public function __construct(

public function onCreationOptions(
PublicKeyCredentialCreationOptions $publicKeyCredentialCreationOptions,
PublicKeyCredentialUserEntity $userEntity
PublicKeyCredentialUserEntity $userEntity,
?Request $request = null,
): Response {
$data = $this->normalizer->normalize($publicKeyCredentialCreationOptions, JsonEncoder::FORMAT, [
AbstractObjectNormalizer::SKIP_NULL_VALUES => true,
Expand Down
4 changes: 3 additions & 1 deletion src/symfony/src/Security/Handler/DefaultRequestOptionsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use RuntimeException;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\Encoder\JsonEncoder;
use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
Expand All @@ -23,7 +24,8 @@ public function __construct(

public function onRequestOptions(
PublicKeyCredentialRequestOptions $publicKeyCredentialRequestOptions,
?PublicKeyCredentialUserEntity $userEntity
?PublicKeyCredentialUserEntity $userEntity,
?Request $request = null
): Response {
$data = $this->normalizer->normalize($publicKeyCredentialRequestOptions, JsonEncoder::FORMAT, [
AbstractObjectNormalizer::SKIP_NULL_VALUES => true,
Expand Down
11 changes: 9 additions & 2 deletions src/symfony/src/Security/Handler/DefaultSuccessHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,18 @@
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
use Webauthn\PublicKeyCredential;
use Webauthn\PublicKeyCredentialOptions;
use Webauthn\PublicKeyCredentialUserEntity;

final class DefaultSuccessHandler implements SuccessHandler, AuthenticationSuccessHandlerInterface
{
public function onSuccess(Request $request): Response
{
public function onSuccess(
Request $request,
?PublicKeyCredential $publicKeyCredential = null,
?PublicKeyCredentialOptions $publicKeyCredentialOptions = null,
?PublicKeyCredentialUserEntity $userEntity = null
): Response {
$data = [
'status' => 'ok',
'errorMessage' => '',
Expand Down
4 changes: 3 additions & 1 deletion src/symfony/src/Security/Handler/RequestOptionsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Webauthn\Bundle\Security\Handler;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Webauthn\PublicKeyCredentialRequestOptions;
use Webauthn\PublicKeyCredentialUserEntity;
Expand All @@ -12,6 +13,7 @@ interface RequestOptionsHandler
{
public function onRequestOptions(
PublicKeyCredentialRequestOptions $publicKeyCredentialRequestOptions,
?PublicKeyCredentialUserEntity $userEntity
?PublicKeyCredentialUserEntity $userEntity,
?Request $request = null
): Response;
}
10 changes: 9 additions & 1 deletion src/symfony/src/Security/Handler/SuccessHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Webauthn\PublicKeyCredential;
use Webauthn\PublicKeyCredentialOptions;
use Webauthn\PublicKeyCredentialUserEntity;

interface SuccessHandler
{
public function onSuccess(Request $request): Response;
public function onSuccess(
Request $request,
?PublicKeyCredential $publicKeyCredential = null,
?PublicKeyCredentialOptions $publicKeyCredentialOptions = null,
?PublicKeyCredentialUserEntity $userEntity = null
): Response;
}
11 changes: 9 additions & 2 deletions src/symfony/src/Service/DefaultSuccessHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,18 @@
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Webauthn\Bundle\Security\Handler\SuccessHandler;
use Webauthn\PublicKeyCredential;
use Webauthn\PublicKeyCredentialOptions;
use Webauthn\PublicKeyCredentialUserEntity;

final class DefaultSuccessHandler implements SuccessHandler
{
public function onSuccess(Request $request): Response
{
public function onSuccess(
Request $request,
?PublicKeyCredential $publicKeyCredential = null,
?PublicKeyCredentialOptions $publicKeyCredentialOptions = null,
?PublicKeyCredentialUserEntity $userEntity = null
): Response {
$data = [
'status' => 'ok',
'errorMessage' => '',
Expand Down
11 changes: 9 additions & 2 deletions tests/symfony/functional/SuccessHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,18 @@
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
use Webauthn\Bundle\Security\Handler\SuccessHandler as SuccessHandlerInterface;
use Webauthn\PublicKeyCredential;
use Webauthn\PublicKeyCredentialOptions;
use Webauthn\PublicKeyCredentialUserEntity;

final class SuccessHandler implements AuthenticationSuccessHandlerInterface, SuccessHandlerInterface
{
public function onSuccess(Request $request): Response
{
public function onSuccess(
Request $request,
?PublicKeyCredential $publicKeyCredential = null,
?PublicKeyCredentialOptions $publicKeyCredentialOptions = null,
?PublicKeyCredentialUserEntity $userEntity = null
): Response {
$data = [
'status' => 'ok',
'errorMessage' => '',
Expand Down
Loading