feat(linter) eslint-plugin-react/jsx-key#1016
Merged
Merged
Conversation
CodSpeed Performance ReportMerging #1016 will not alter performanceComparing Summary
|
Member
|
@camc314 I gave you triage permission so you can update the corresponding issues https://github.com/web-infra-dev/oxc/invitations You may give me a wave on our discord channel if you want to get more involved https://discord.gg/9uXCAwqQZW. |
Boshen
reviewed
Oct 20, 2023
Boshen
reviewed
Oct 20, 2023
Boshen
reviewed
Oct 20, 2023
Boshen
reviewed
Oct 20, 2023
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
Thank you for the amazing work! Just a few above questions and we'll get this merged!
camc314
commented
Oct 20, 2023
Member
|
Let's merge this first and then rebase the other PR. Seems like there is a clippy error, and some commented out tests. |
Boshen
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-key.md