Skip to content

feat(linter): implement no-var-requires#575

Merged
Boshen merged 5 commits into
oxc-project:mainfrom
makotot:linter/rules/ts/no_var_requires
Jul 21, 2023
Merged

feat(linter): implement no-var-requires#575
Boshen merged 5 commits into
oxc-project:mainfrom
makotot:linter/rules/ts/no_var_requires

Conversation

@makotot
Copy link
Copy Markdown
Contributor

@makotot makotot commented Jul 19, 2023

Related to #503

I have tried to implement https://typescript-eslint.io/rules/no-var-requires/ .

@github-actions github-actions Bot added the A-linter Area - Linter label Jul 19, 2023
Comment thread crates/oxc_linter/src/rules/typescript/no_var_requires.rs
@makotot makotot marked this pull request as ready for review July 19, 2023 18:04
Comment thread crates/oxc_linter/src/rules/typescript/no_var_requires.rs
Comment thread crates/oxc_linter/src/rules/typescript/no_var_requires.rs Outdated
@makotot
Copy link
Copy Markdown
Contributor Author

makotot commented Jul 20, 2023

@Boshen Thanks for the review! I've tried to fix it and would like to ask you to check it again 🙏

@makotot makotot requested a review from Boshen July 20, 2023 12:28
@Boshen Boshen merged commit 52c3c37 into oxc-project:main Jul 21, 2023
@Boshen
Copy link
Copy Markdown
Member

Boshen commented Jul 21, 2023

Thank you for your first contribution!

@makotot makotot deleted the linter/rules/ts/no_var_requires branch July 21, 2023 03:13
@makotot makotot changed the title feat(linter): implement no-var-requires feat(linter): implement no-var-requires Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants