fix: source map source path when using multiple environments #6456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with source map generation when using multiple environments with different output paths. The fix ensures that source paths in source maps are correctly calculated relative to each environment's specific distPath rather than using a shared global path.
Key Changes:
- Updated the source map plugin to use environment-specific
distPathinstead of the global context'sdistPath - Added test coverage for multi-environment source map generation
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/plugins/sourceMap.ts | Changed to use environment-specific distPath parameter instead of global context |
| e2e/cases/source-map/multi-environments/src/index.js | Added simple test source file |
| e2e/cases/source-map/multi-environments/rsbuild.config.ts | Added test configuration with two environments having different output paths |
| e2e/cases/source-map/multi-environments/index.test.ts | Added test to verify correct relative paths in source maps for each environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix source map source path when using multiple environments, see #6450 (comment)
Checklist