Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

If source map generation is disabled, it may take a few milliseconds to traverse all assets. This PR resolved the issue.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 28, 2025 08:53
@netlify
Copy link

netlify bot commented Oct 28, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 2813f3b
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/690087a2b8582000095d9296
😎 Deploy Preview https://deploy-preview-6457--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 58 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the source map plugin by skipping asset traversal when source map generation is disabled, reducing unnecessary processing time by a few milliseconds.

Key Changes:

  • Extracted CSS source map check into a reusable enableCssSourceMap helper function
  • Added early return in the processAssets hook when both JS and CSS source maps are disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 3e5f9ec into main Oct 28, 2025
11 checks passed
@chenjiahan chenjiahan deleted the skip_source_map_processing_1028 branch October 28, 2025 09:19
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants