Skip to content

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Oct 21, 2025

Summary

  • Extract some reusbable setup logic
  • Split tests to ut / intergration / e2e
  • Do not run tests on Node.js 20, only run on Node.js 18 and 22
  • Run windows tests on Node.js 22
image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 21, 2025 10:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CI test workflow by extracting common test logic into a reusable workflow file and removes Node.js 20 from the test matrix, keeping only versions 18 and 22.

Key Changes:

  • Extracted reusable test workflow to eliminate duplicated CI code
  • Removed Node.js 20 from the test matrix across all jobs
  • Split combined integration-e2e job into separate integration-e2e and e2e jobs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test.yml Simplified workflow by removing duplicated steps and calling reusable workflow with matrix strategy for different runners and Node versions
.github/workflows/reusable-test.yml New reusable workflow containing extracted common test logic with conditional execution based on task type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Timeless0911 Timeless0911 force-pushed the refactor-ci branch 2 times, most recently from 72844c9 to c9e8254 Compare October 21, 2025 11:03
@Timeless0911 Timeless0911 merged commit d1ac8f1 into main Oct 21, 2025
20 checks passed
@Timeless0911 Timeless0911 deleted the refactor-ci branch October 21, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants