feat: log a flag to mark first compile done in watch mode #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
fi3ework
November 11, 2025 12:20
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a feature to log "build complete, watching for changes..." when the first compilation finishes in watch mode, enabling external tools to detect when the initial build is ready.
- Adds a plugin that hooks into
onAfterBuildto log a success message on first compile - Modifies
runClitest helper to capture stdout/stderr and return an object with the child process - Updates test to verify the new log message appears
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/cli/commands.ts | Adds plugin to log completion message in watch mode after first compile |
| tests/scripts/shared.ts | Modifies runCli to capture stdout/stderr and return wrapper object |
| tests/integration/cli/build-watch/build.test.ts | Updates test to verify new log message and use new runCli return structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 12, 2025
Timeless0911
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
other tools will know when the very first compile is done by matching this log in watch mode.
Related Links
Checklist